What makes for a good game publishing contract?

Raw Fury (Kingdom, Backbone) has made public its full publishing agreement, including revenue % - as has Whitethorn Digital. What are they like, and what should we take away? Opinions within... ...